fix(clients): initialize page variable in Ruby helpers #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
Fluf22
approved these changes
Sep 22, 2025
|
@kai687 okay to merge? |
|
Yes, I don't have permissions to merge here, so if you would be so kind @Fluf22 |
|
I always forget, sorry |
algolia-bot
added a commit
that referenced
this pull request
Sep 24, 2025
…ated) [skip ci] Co-authored-by: Kai Welke <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
algolia-bot
added a commit
to algolia/algoliasearch-client-ruby
that referenced
this pull request
Sep 24, 2025
algolia/api-clients-automation#5370 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Kai Welke <[email protected]> Co-authored-by: Thomas Raffray <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Initializes the
:pageparameter for Ruby'sbrowse_synonymsandbrowse_rulesparameters to avoid the issue described in #5367.🎟 GitHub issue:
closes #5367.
Changes included:
:pageto 0 if it'snilorfalseinbrowse_synonymsandbrowse_rules:hitsPerPage🧪 Test
I didn't find any tests for these methods, but it would be nice to test. No idea how.